From 25ed9735bfce2a4982751653f715e1987f8df487 Mon Sep 17 00:00:00 2001
From: Liuyang <2746366019@qq.com>
Date: Sat, 15 Mar 2025 12:24:20 +0800
Subject: [PATCH] =?UTF-8?q?refactor(yudao-module-llm):=20=E4=BC=98?=
 =?UTF-8?q?=E5=8C=96=E7=9F=A5=E8=AF=86=E5=BA=93=E6=B5=8B=E8=AF=95=E6=8E=A5?=
 =?UTF-8?q?=E5=8F=A3=E7=9A=84=E5=8F=82=E6=95=B0=E5=A4=84=E7=90=86=E9=80=BB?=
 =?UTF-8?q?=E8=BE=91?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- 设置 topK 和 score 的默认值
- 优化 topK 和 score 的处理逻辑，确保使用合适的值
- 移除不必要的条件判断，简化代码结构
---
 .../KnowledgeBaseServiceImpl.java              | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/yudao-module-llm/yudao-module-llm-biz/src/main/java/cn/iocoder/yudao/module/llm/service/knowledgebase/KnowledgeBaseServiceImpl.java b/yudao-module-llm/yudao-module-llm-biz/src/main/java/cn/iocoder/yudao/module/llm/service/knowledgebase/KnowledgeBaseServiceImpl.java
index 916b5cd3c..6b4108585 100644
--- a/yudao-module-llm/yudao-module-llm-biz/src/main/java/cn/iocoder/yudao/module/llm/service/knowledgebase/KnowledgeBaseServiceImpl.java
+++ b/yudao-module-llm/yudao-module-llm-biz/src/main/java/cn/iocoder/yudao/module/llm/service/knowledgebase/KnowledgeBaseServiceImpl.java
@@ -295,25 +295,23 @@ public class KnowledgeBaseServiceImpl implements KnowledgeBaseService {
         if (baseDO == null) {
             throw exception(KNOWLEDGE_BASE_NOT_EXISTS);
         }
+        // 设置默认值
         Integer topK = 4;
+        Double score = 0.2;
+
+        // 处理 topK 的逻辑
         if (baseDO.getTopK() == null || baseDO.getTopK() <= 0) {
             testReqVO.setTopK(topK);
-            if (testReqVO.getTopK() == null){
-                testReqVO.setTopK(baseDO.getTopK());
-            }
         } else {
-            topK = testReqVO.getTopK();
+            topK = testReqVO.getTopK() != null ? testReqVO.getTopK() : baseDO.getTopK();
             testReqVO.setTopK(topK);
-            if (testReqVO.getScore() == null){
-                testReqVO.setScore(baseDO.getScore());
-            }
         }
 
-        Double score = 0.2;
-        if (baseDO.getScore() == null || baseDO.getTopK() <= 0.0 || baseDO.getScore() > 1) {
+        // 处理 score 的逻辑
+        if (baseDO.getScore() == null || baseDO.getScore() <= 0.0 || baseDO.getScore() > 1) {
             testReqVO.setScore(score);
         } else {
-            score = testReqVO.getScore();
+            score = testReqVO.getScore() != null ? testReqVO.getScore() : baseDO.getScore();
             testReqVO.setScore(score);
         }